Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchForm search button is not interactive #2976

Closed
rlyonbox opened this issue Aug 8, 2022 · 1 comment · Fixed by #3013
Closed

SearchForm search button is not interactive #2976

rlyonbox opened this issue Aug 8, 2022 · 1 comment · Fixed by #3013
Labels
bug triaged

Comments

@rlyonbox
Copy link
rlyonbox commented Aug 8, 2022

Reported by Boxer, created on their behalf: "Nothing happens when clicking on the magnifying glass in the [ContextExplorerModal]"

Digging into the code a little, this resolves to the type attribute on the button which renders the magnifying glass being button instead of submit on this line:

box-ui-elements/src/components/search-form/SearchForm.js

Line 168 in ef674ae

type="button"

Resolution is trivial, 1 line change, but I'm not sure the provenance of using type=button in the first place.
@greg-in-a-box
Copy link
Contributor
greg-in-a-box commented Aug 10, 2022 •
edited
Loading

Agree with changing the <button/> type to a submit. The unit test needs to be updated to simulate clicking on the button and not invoking the submit event directly

box-ui-elements/src/components/search-form/__tests__/SearchForm.test.js

Line 66 in ef674ae

form.simulate('submit', event);

@QingyuChai QingyuChai linked a pull request Aug 29, 2022 that will close this issue
fix(search-form): fix search button not invoking form submit #3013
Merged
@QingyuChai QingyuChai mentioned this issue Aug 29, 2022
Merged
@mergify mergify bot closed this as completed in #3013 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(search-form): fix search button not invoking form submit QingyuChai/box-ui-elements
2 participants
@rlyonbox @greg-in-a-box