-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin config injection to inflexible due to type check for config path #1602
Comments
github-actions
bot
added
the
lifecycle/stale
Denotes an issue or PR that has become stale and will be auto-closed.
label
Mar 3, 2024
csatib02
removed
the
lifecycle/stale
Denotes an issue or PR that has become stale and will be auto-closed.
label
Mar 24, 2024
github-actions
bot
added
the
lifecycle/stale
Denotes an issue or PR that has become stale and will be auto-closed.
label
May 26, 2024
github-actions
bot
removed
the
lifecycle/stale
Denotes an issue or PR that has become stale and will be auto-closed.
label
Jun 2, 2024
github-actions
bot
added
the
lifecycle/stale
Denotes an issue or PR that has become stale and will be auto-closed.
label
Aug 4, 2024
github-actions
bot
removed
the
lifecycle/stale
Denotes an issue or PR that has become stale and will be auto-closed.
label
Aug 11, 2024
Thank you for your contribution! This issue has been automatically marked as |
github-actions
bot
added
the
lifecycle/stale
Denotes an issue or PR that has become stale and will be auto-closed.
label
Oct 13, 2024
github-actions
bot
removed
the
lifecycle/stale
Denotes an issue or PR that has become stale and will be auto-closed.
label
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
We're trying to bring up our vault with the https://github.com/1Password/vault-plugin-secrets-onepassword plugin fully configured and working. The plugin however does need configuration set at path op/config. The code at https://github.com/banzaicloud/bank-vaults/blob/50de449474cd3dd86a6d585c953608cbe3769944/internal/vault/secrets_engines.go#L229 and subsequently at https://github.com/banzaicloud/bank-vaults/blob/50de449474cd3dd86a6d585c953608cbe3769944/internal/vault/secrets_engines.go#L166 however only allows to use the /config name for a fixed list of engine types but not for the type plugin. This should be clearly configurable and not be a fixed list imho.
Expected behaviour:
In the vault crd, accept the following:
Steps to reproduce the bug:
If you use the config as stated above the vault-configurer complains that it's missing a "name" parameter below the config which would automatically lead it to use that name as path for the config. The onepassword-connect plugin however does need it's config to be written to op/config and no subpath/name is needed.
I've managed to come up with this workaround as a hack:
This tricks the vault-configurer into setting up the plugin path as type plugin and later thanks to
type: kv
being in the allow list for /config paths it accepts the config to be written there.I personally would recommend to have a flag below
configuration:
or at the same level indicating no need for a subpath.Additional context:
I also had issues with the plugin not being executable which I was able to backtrace to the
disable_mlock: true
config option which the default vault chart always sets but the bank-vault crd needs that explicitly set. Using the same helm chart defaults as the original vault setup would be helpful I think.Environment details:
{"level":"error","msg":"error configuring vault: error configuring secret engines for vault: error adding secrets engines: error finding sub config data name for secret engine: op/config","time":"2022-04-29T09:30:12Z"}
/kind bug
The text was updated successfully, but these errors were encountered: