[Babel 8] Remove some Scope methods
#16705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57810 |
Scope#{traverse,_renameFromMap}Scope methods
liuxingbaoyu
commented
Jul 31, 2024
Comment on lines
48
to
57
| } else if (typeof i === "number") { | ||
| args.push(t.numericLiteral(i)); | ||
|
|
||
| // Used in array-rest to create an array from a subset of an iterable. | ||
| helperName = "slicedToArray"; | ||
| // TODO if (this.hub.isLoose("es6.forOf")) helperName += "-loose"; | ||
| } else { | ||
| // Used in array-rest to create an array | ||
| helperName = "toArray"; | ||
| } |
There was a problem hiding this comment.
In this file i is always true, right?
| @@ -193,7 +248,7 @@ export class DestructuringTransformer { | |||
| ) { | |||
| return node; | |||
| } else { | |||
| return this.scope.toArray(node, count, this.arrayLikeIsIterable); | |||
| return toArray(this.scope, node, count, this.arrayLikeIsIterable); | |||
There was a problem hiding this comment.
Can we maybe inline the toArray function here, given that this method is very short and already called toArray?
|
|
||
| let helperName; | ||
| const args = [node]; | ||
| if (i === true) { |
f82fcb2
to
846227a
Compare
nicolo-ribaudo
approved these changes
Aug 28, 2024
d76ac15
to
2ef5c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2