Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop Client may freeze on closing window #696

Open
nhnb opened this issue Mar 31, 2024 · 4 comments
Open

Desktop Client may freeze on closing window #696

nhnb opened this issue Mar 31, 2024 · 4 comments
Assignees
@nhnb
Labels
component: desktop client component: webview (desktop) Related to web client embedded in desktop WebView. type: bug Causes a negative impact or not working as intended.

Comments

@nhnb
Copy link
Member
nhnb commented Mar 31, 2024 •
edited
Loading

🐞 Describe the bug

When the client window is closed, it may take 30 seconds until the windows disappeares and the process exitd.

🔥 How to reproduce

The issue occurs on both the X button on the title bar and the window menu close item.

The issue can be reproduced extra time on a specific PC with Microsoft Windows. It does not happen on my PC with Linux.

The issue occurs with and without the nativehelper extension.

🌍 Environment

  • Desktop Client
@nhnb nhnb added type: bug Causes a negative impact or not working as intended. component: desktop client labels Mar 31, 2024
@nhnb nhnb self-assigned this Mar 31, 2024
@AntumDeluge
Copy link
Member
AntumDeluge commented Jun 5, 2024 •
edited
Loading

I experienced this today after launching from Steam on Windows. Closed the client window using "X" button (which took 15-30 seconds for window to close). But process was still open in background as I had to press the "X STOP" button in the Steam app to end it.

More details:

After closing Steam launched client, stendhal-client-win_x64.exe process remains open in background. However, after closing client launched from Windows Explorer, the process appears to end correctly as it is not longer listed in the task manager. (Note: using Neutralinojs executable built locally)

Edit: The issue of the process remaining open appears to be separate: #736

@AntumDeluge AntumDeluge added component: webview (desktop) Related to web client embedded in desktop WebView. labels Jun 5, 2024
@AntumDeluge
Copy link
Member
AntumDeluge commented Jun 5, 2024 •
edited
Loading

It appears to be a problem with the Neutralinojs executable, as the same behavior occurs with the character generator app.

Note: Updating to current release of Neutralinojs didn't help.

@AntumDeluge AntumDeluge mentioned this issue Jun 5, 2024
Open
@AntumDeluge
Copy link
Member
AntumDeluge commented Jun 6, 2024 •
edited
Loading

Found a bug report that sounds like it is related to our issue: neutralinojs/neutralinojs#1179

There is a workaround mentioned, but I haven't examined it yet.

Edit: Nevermind, our app already employs the same code.

@AntumDeluge AntumDeluge mentioned this issue Jun 6, 2024
Open
@AntumDeluge
Copy link
Member

I can use Ctrl+C to close the app immediately when executed from a command prompt using neu run. Not sure if that is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhnb nhnb

Labels
component: desktop client component: webview (desktop) Related to web client embedded in desktop WebView. type: bug Causes a negative impact or not working as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhnb @AntumDeluge