-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up codesigning and ensure signing success #17
Comments
@Asher- Codesign is okay for me (Adium 1.5.10.4 on macOS 11.2.2). |
I'm not sure what you mean. This issue concerns deployment of compiled sources to bundle a new Adium.app. The problem is that the (very old) build scripts create the dylibs and then frameworkerize them without any code signing. When Xcode performs its copy phase and goes to sign the frameworks, it does so by signing the bundled /A file, expecting everything else to already be signed; instead, it finds that nothing is signed and bails. Adium used to handle this by using --force --deep, but this is improper (and has been clarified as such by Apple more recently) and further did not work properly in all cases. The proper solution is to codesign the dylibs as they are generated. This is not of itself difficult, but it requires the build scripts to be in working order— which they were not. They are now in mostly working order, with a few further details to be resolved, at which point codesigning can be easily integrated. The only detail that I am not sure of offhand is how to use Xcode's automatic signing selection from the build script. I'm hoping Google knows. |
@Asher- What I am saying is that the disk image should sign properly on my computer. |
This concerns signing of the binary, before any disk image is created. |
@Asher- I have no binary, only dmg. |
Please don't comment on issues you don't understand unless it is to ask pertinent questions that lead to an understanding. |
How do you know I don't understand this? |
If you understood this, you would be able to identify the evidence yourself. |
@Asher- I don't have the binary to identify the evidence. |
Issues related to dependencies are causing codesign to fail unless deep is specific, which is not recommended.
Sorting this out is rather opaque, so probably requires step by step cleaning up the dependencies.
The text was updated successfully, but these errors were encountered: