Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New addok-csv 1.1.0 is 5-10x slower #734

Open
jdesboeufs opened this issue Oct 23, 2022 · 1 comment
Open

New addok-csv 1.1.0 is 5-10x slower #734

jdesboeufs opened this issue Oct 23, 2022 · 1 comment
Labels
CSV

Comments

@jdesboeufs
Copy link
Member

I tried the new version 1.1.0 published yesterday (to dismiss a WSGI warning when addok-csv is used with addok@1.0.3).

My usual benchmark show a performance drop on Python 3.6 and 3.10.
With addok-csv@1.0.1, 20000 trivial rows were geocoded in 4 seconds (with 8 workers / chunks of 100 rows).
Now there are geocoded in ~25secondes, which is even slower than atomic HTTP requests.
@jdesboeufs jdesboeufs changed the title New version addok-csv 1.1.0 is 5-10x slower New addok-csv 1.1.0 is 5-10x slower Oct 23, 2022
@yohanboniface
Copy link
Member

My first bet is addok/addok-csv@7957042

Needs investigation.

@jdesboeufs jdesboeufs added the CSV label Apr 9, 2023
@jdesboeufs jdesboeufs mentioned this issue Oct 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSV
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yohanboniface @jdesboeufs