Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @zhaozhang it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿

To fix this do the following two things:

1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

2. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

For a list of things I can do to help you, just type:

@whedon commands

Hi @lmcinnes

Please fix the formatting of the paper part of your submission. See https://github.com/mpastell/Weave.jl/blob/master/paper/paper.md for an example of another current submission that has a properly formatted paper. By this, I refer to two things:

1. the metadata: your line 12 needs one more space at the start.
2. references to items in the bibliography. Only items that are referenced in the text will be shown in the bibliography when the paper is compiled, and you currently don't refer to any of them.

Thanks.

Thanks - there were also a couple more things I saw, so I put in a pull request.

Thank you! Merged.

Hi @lmcinnes,

I have found the following points during installation:

1. hdbscan depends on scipy also, it was not documented in the instruction manual.
2. it works with both Python2 and Python3, please document this.
3. The code examples in README.md are not self-contained, please replace "data" with some example dataset.

Please also include community guidelines:

1. Contribute to the software.
2. Report issues or problems with the software.
3. Seek support.

Please add DOI for the references in paper.bib.

Best,
Zhao

Hi @zhaozhang

Thanks for taking the time to look through everything. I've attempted to remedy each of these points. My only issue is that there does not appear to be a DOI for "Rates of convergence for the cluster tree" from NIPS 2010 (NIPS proceedings seem to forego DOIs for reasons that are not clear to me). Any recommendations on that front would be appreciated.

If there's no DOI for a reference, then you don't need to supply one :)

JOSS just wants to be sure that where there is a DOI, it's used.

Hi @zhaozhang

If the authors have addressed your points, please update the checkboxes and let me know here that you think is ready to be accepted.

If not, please continue to work with the authors on what you think is needed.

Hi @danielskatz

Yes, I have update the checkboxes. I think it is ready to be accepted.

@arfon, over to you for the next steps.

@zhaozhang, thanks for the quick work in suggesting changes

@lmcinnes, thanks for your quick work in responding to the suggestions.

@lmcinnes - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.

@whedon set 10.5281/zenodo.401403 as archive

OK. 10.5281/zenodo.401403 is the archive.

@zhaozhang many thanks for the review here and @danielskatz for editing this paper ✨

@lmcinnes - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00205 ⚡️ 🚀 💥