-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Description
I got two build warnings today when building master (f169c6c at the time of creating this issue):
first is C4459: bufferedProtocols is declared as a global, but the ref is being passed as function argument raising a warning about conflict of variable names, is this intended?
std::vector<Protocol_ptr> bufferedProtocols;
void sendAll(const std::vector<Protocol_ptr>& bufferedProtocols);
second is C4245 in:
const Town* town = g_game.map.towns.getTown(tfs::lua::getField<uint32_t>(L, 2, "id", -1));
default value is set to -1, but the function is fetching u32 here, -1 will result in an underflow. Should
it use std::numeric_limits<uint32_t>::max()
to retain its current behaviour or default it to zero?
Metadata
Metadata
Assignees
Labels
No labels