Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted syncing of all files w/ 3.30.1 #13738

Closed
4 tasks done
d00r5 opened this issue Oct 8, 2024 · 252 comments · Fixed by #13838
Closed
4 tasks done

Unwanted syncing of all files w/ 3.30.1 #13738

d00r5 opened this issue Oct 8, 2024 · 252 comments · Fixed by #13838

Comments

@d00r5
Copy link
d00r5 commented Oct 8, 2024

⚠️ Before posting ⚠️

  • This is a bug, not a question or an enhancement.
  • I've searched for similar issues and didn't find a duplicate.
  • I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
  • I agree to follow Nextcloud's Code of Conduct.

Steps to reproduce

  1. Sync only certain files
  2. Wait several minutes for the app to check updates
  3. The entirety of the files get synced
  4. Delete locally all files that are wrongly being synced
  5. Wait several minutes for the app to check updates
  6. The entirety of the files get synced

Expected behaviour

It should not sync files that were not explicitly synced previously

Actual behaviour

It syncs all files every time

Android version

14

Device brand and model

Pixel 7a

Stock or custom OS?

Custom (explain in "additional information")

Nextcloud android app version

3.30.1 RC1

Nextcloud server version

29.0.0

Using a reverse proxy?

I don't know

Android logs

No response

Server error logs

No response

Additional information

GrapheneOS
Logs contain personal informations that I don't want to share publicly (file names etc), hence no logs are attached

@joshtrichards
Copy link
Member

The entirety of the files get synced

By synced do you mean green icon appears on the files?

What other files are you seeing being synced? Files in other folders? Files in the same folder? etc.

@d00r5
Copy link
Author
d00r5 commented Oct 9, 2024

Yes. I decide to sync (green icon) only two files at the root of my Nextcloud (/Passwords.kdbx and /Notes.md).
They are listed in the "on device" tab.
But after some time, I see that the app syncs (green icon and listed "on device") the entirety (all files and folders under root /, for example /Documents/id.pdf, /Documents/resume.pdf…).
The internal two way sync option in settings lists all files contained in my Nextcloud too and I cannot remove any of them.

If I try to delete locally all these folders, they aren't removed from this list (internal two way sync) and keep being synced.

@d00r5
Copy link
Author
d00r5 commented Oct 9, 2024

#13747 and #13752 may be related as it syncs everything even when no files changed and the entirety of the files

@zeigerpuppy
Copy link

Confirming this behaviour... unwanted syncing of all files

  • Lineage OS (Oneplus 11 Pro)
  • latest Nextcloud Dev installed from F-droid.

@butterfly78
Copy link
butterfly78 commented Oct 11, 2024

Here too,

  • Android 14 (HyperOS 1.0.5.0) on Xiaomi 11T pro
  • latest Nextcloud DEV from F-droid (20241008)
  • Nextcloud Server Version 30.0.1 RC1

@robelix
Copy link
robelix commented Oct 14, 2024

Here, too

  • Android 14 / Lineage-microG on a Motorola edge 30
  • Nextcloud Server 29.0.8
  • Nextcloud dev 20241008 from F-droid

Updated Nextcloud dev from F-droid yesterday - then it started downloading everything from my Nextcloud.
I did never set up any 2-way sync, only auto-upload for pictures and videos. No Idea how to disable sync - the settings -> 2-way-sync opens a long list of files and folder where I can't do anything. Had to disable Wifi and mobile Data to stop it from downloading.

@foss-
Copy link
foss- commented Oct 15, 2024

This is a major issue to the point where pulling the update should be considered. Not sure what the policies for blocker bugs are, but this certainly is a good candidate. Since @joshtrichards is involved nextcloud is aware. But I am astonished that no further reaction happened so far. I had to downgrade the android app and this has caused more than a small disruption.

@alxrdn
Copy link
alxrdn commented Oct 15, 2024

This is indeed a very significant disruption: filling up local storage, draining battery, over consuming network bandwidth, over loading server, ...

@develop-Greenant
Copy link

Hi @foss- out of interest, which version did you downgrade to? Will have to to the same!

@Q3x7Dvh
Copy link
Q3x7Dvh commented Oct 15, 2024

Hi @foss- out of interest, which version did you downgrade to? Will have to to the same!

3.30.0 worked for me.

@foss-
Copy link
foss- commented Oct 16, 2024

3.30.0 indeed works. Make sure, if you are using F-Droid, to disable automatic updates. I just got updated to the broken version again 🤦

There is a two week old PR which reads as if it would address this problem. So far review is pending: #13683

@DerDreschner
Copy link

I have the same issue. Downgrading to 3.30.0 solved the issue for me as well.

  • Android 13 (Fairphone 4)
  • App 3.30.1 directly from repository (via Obtanium, non-gplay-apk)
  • Server 30.0.0

@zeigerpuppy
Copy link

Thanks for the tip on getting older version @DerDreschner

For anyone who is interested, I had a bit of an interesting time purging all the downloaded files (some of which I don't want on my device). The nextcloud files were not stored in a directory, they are stored in the media storage (which is a referenced object store from what I can work out). Files there can only be deleted by the app which created them (so I had not access after removing nextcloud app).

Anyway, it can be done via USB debugging...

  1. enable developer options on phone
  2. in developer options, enable USB debugging and Rooted debugging
  3. use the adb commands from your connected computer (in my case, Devuan Linux)

get the connected devices

adb devices

get root

adb root

you will need to accept a permission request on the phone

adb shell

you may be asked again for permission

then run this command to clear storage:

pm clear com.android.providers.media.module 

reset the phone after this command and all the files in the media store will be nuked.

! be careful with this, it worked for me but may delete your treasured cat photos - perhaps even in other apps!

@the-voidl
Copy link
the-voidl commented Oct 18, 2024

Same issue - after an upgrade to Nextcloud 3.30.1 it started to download all files from my account.

  • LineageOS 21 (Android 14)
  • Nextcloud F-Droid 3.30.1

After downgrading to Nextcloud 3.30.0 it seems I can click the three dots on a folder and "stop sync". Though I had to do it for a lot of subfolders.

In 3.30.1 it was not even possible to "stop" syncing any folder in the 3-dot-menu.
Also in 3.30.1 I cannot edit the 2-way-sync list in any manner manually. Is that intended?

@solonovamax
Copy link

I'm experiencing the same issue. I cannot cancel the sync by any means.

this is a serious issue, as it is attempting to sync nearly a hundred gigs of photos and video for me, and I haven't even been using nextcloud that long. I'm sure there are others who have hundreds of gigs stored in nextcloud.

@BITS-Editor
Copy link

Same here, Android 14 stock, v3.30.1 F-Droid

I have uninstalled the app now - which is a pity.

@xlash123
Copy link

I can also confirm it was working fine on 3.30.0. I just upgraded to 3.30.1 and discovered this was happenning because my phone got unusually hot. I tried unticking the "Sync" checkbox in details, but even after deleting the files locally, it began to download again. For now, I'll just leave the network permission disabled.

Android 13, /e/OS 2.4.1-t

@licaon-kter
Copy link
licaon-kter commented Oct 18, 2024

disabled 3.30.1 in https://gitlab.com/fdroid/fdroiddata/-/commit/1f73fe95c6b6e405d962e0d525aa1fa2f2d4a854 (it will go away in 2 cycle though)

regarding the Dev version, what's its status? is latest 20241012 still faulty?

@Kitt3120
Copy link
Kitt3120 commented Oct 18, 2024

Pixel 9 Pro XL with GrapheneOS and Nextcloud 3.30.1 through F-Droid. Same problem. I just noticed that I got a bunch of notifications, and now my phone is trying to sync 2 TiB of data.

Downgraded to 3.30.0 and everything is fine again.

@xlash123
Copy link

I just installed version 20241016 of dev. I haven't encountered the bug with it. I even forced synced a folder to see if it would trigger it.

I also installed 3.30.1 on a work profile on my phone (to avoid deleting my current install) and set it up. I also haven't had that start downloading everything. Could this be an issue only with client upgrades?

@licaon-kter
Copy link

@xlash123 do test upgrades too then :)

@joshtrichards joshtrichards pinned this issue Oct 18, 2024
@Alifoss
Copy link
Alifoss commented Oct 25, 2024

I have about 4tb on my server, and every file is recognized as folder. I've deleted in internal storage > Android > media > com.android.client every subfolder to hope that that would fix it. This didn't sync started immediatly again after.

Do you think, that it would fix this new issue, if the app would stop syncing when reaching a warning limit and offer to skip syncing the remaining files once? I seems that this would similar to this suggestion #13873

I guess that would improve the situation as is, but preferably i would like to disbale 2 way sync completely with a simple setting.

I think i will dig up my arduino and adapt this code : https://www.hackster.io/nick-engmann/swiper-auto-tinder-bumble-swiper-d0ebf6 to press 'x' for half a day.

@ltguillaume
Copy link

@Alifoss You could just use https://github.com/Genymobile/scrcpy and any auto-clicker.

@githubtefo
Copy link

After upgrade in F-droid tonight I did manually removed one by one all the list in two-way sync (took me half an hour).
Also click on cancel sync on all of my folder.
Despite all of this, the App keeps like crazy with the sync of everything.
What should I missing here?

@f45tb00t
Copy link
f45tb00t commented Oct 26, 2024

@RikkiBC

but can we please keep the comments focused on the (now resolved) issue?

;D

But at least to tell something productive: For me it seems it does not sync over and over again. But I had to use the X many times to remove everythig from the 2 way sync. Obviosuly not very efficient this way.

Just wondering where would I TURN OFF the 2 way sync? Especially since I NEVER enabled it?!

@RikkiBC
Copy link
RikkiBC commented Oct 26, 2024

For myself to add to the collective data: I'd fixed it while it was 3.30.1 by clearing app cache and data, then re-logging in and re-setting up my auto-upload folders. I've just upgraded to 3.30.2 from F-Droid and the bug has not re-appeared, so it does really seem like whatever was done to fix this does not help users who have gone from a pre-3.30.1 version to 3.30.2.

EDIT: Slightly more to this story, I was mistaken. See comment by @ltguillaume below: #13738 (comment)

@RikkiBC

but can we please keep the comments focused on the (now resolved) issue?

;D

Not sure what this means? I stand by my earlier comments, we should still attempt to keep comments focused on the issue (if the only problem you have is with my use of the word "resolved", that was based on this issue having had an attempted fix pushed and this issue closed. None of my comments were me saying "that'll definitely be all and we should stop monitoring this"). We were (almost) all waiting for the next release to come out before we could test it again, and people continuing to send repetitive notifications to around 100 participants about unrelated stuff didn't make anything better or move faster.

@gagio
Copy link
gagio commented Oct 26, 2024

The comments are getting me more and more confused. What should a not neerdy user do?

First, thank you devs for your work developing this app, which always worked perfect till 3.30.1 for me. I'm shure you are trying to do the best.

But second, we need a little tutorial, for users upgrading from 3.30.0 and from the buggy version 3.30.1. What should be done before and after getting to 3.30.2 from f-droid.

And why doesn't exist a turning off of the 2-way-sync?
This could avoid a lot of trouble in this troubled world.

@ltguillaume
Copy link
ltguillaume commented Oct 26, 2024

so it does really seem like whatever was done to fix this does not help users who have gone from a pre-3.30.1 version to 3.30.2.

@RikkiBC That's not the case. After the v3.30.1 fiasco, I downgraded to v3.29.3 F-Droid (available here) and set everything up.

Now I updated to v3.30.2 directly (skipping v3.30.1) and no two-way sync issues have occurred.

So, the issue is only instigated if you had installed the app before v3.30.0 and updated to v3.30.1 at any point, because that would cause all null values to be set to 0L in the database, effectively enabling two-way sync for every file and folder.

@RikkiBC
Copy link
RikkiBC commented Oct 26, 2024

So, the issue is only instigated if you had installed the app before v3.30.0 and updated to v3.30.1 at any point, because that would cause all null values to be set to 0L in the database, effectively enabling two-way sync for every file and folder.

Ah thanks for that! I've updated my comment to point to this clarification.

Just so it's clear in my head though: If a user hasn't updated to 3.30.1, but now skips ahead to later versions, they won't encounter this? I.e, it's resolved for people who don't ever see 3.30.1, but still as yet unresolved for anyone who has gone to 3.30.1 and hasn't yet either downgraded then upgraded to later versions, or otherwise cleared app cache and data on 3.30.1 (both options being imperfect of course)? Thanks in advance for this response.

@ltguillaume
Copy link

@RikkiBC Yeah that's correct.

@sebeweiss
Copy link

Have you checked that Synchronise for the folders is disabled in the details view?

It seems to work fine for me.
My road to silence:
Updated to 3.30.1 via F-Droid -> got the error
Uninstalled 3.30.1
Installed 3.30.0
Now updated from 3.30.0 to 3.30.2 -> it seems to be fine, my 2-way-sync-list is empty

@alperozturk96
Copy link
Collaborator

Hello everyone,

I’m truly sorry for the negative experience many of you have had. We know that an apology alone won’t fix things, but I want you to know we’re committed to making it right.

After reviewing the latest release, I’ve noticed some issues and areas where we can make improvements, so I’ve opened a pull request to address these.

With this update, you’ll be able to disable two-way sync if you choose, or set it to run on your preferred schedule. You’ll also no longer need to manually cancel syncing for each unwanted file. Upon launch only one time, the app will automatically set the internalFolderSyncTimestamp to -1 for all files, giving us a fresh start.

I’ll work to release these improvements as soon as possible. Of course, our team will need time to review, test and approve this PR, which may take a little while. During this time, I’ll try to write automated tests to ensure everything runs smoothly.

Once again, I apologize and appreciate your patience and support as we work through this.

@ltguillaume
Copy link
ltguillaume commented Oct 26, 2024

@alperozturk96 What about automatically removing all those local copies with this update to actually solve all the problems caused by 3.30.1? Many people will still have no idea that, or why their phone's storage is suddenly (almost) full. Or are the two-way synced files not distinguishable from local copies the user has synced manually?

@Tonus1
Copy link
Tonus1 commented Oct 26, 2024

Hi all
After upgrading, got to do the following to stop the faulty behavior :
Airplane mode
Clear the 2 way sync queue for all accounts
Clear cache
Revert Airplane mode

Hope it would help to solve things without uninstall and lose config.

Regards

@githubtefo
Copy link

Hi all After upgrading, got to do the following to stop the faulty behavior : Airplane mode Clear the 2 way sync queue for all accounts Clear cache Revert Airplane mode

Hope it would help to solve things without uninstall and lose config.

Regards

This works for me! There was an attempt to "download" whatever was already downloaded in the phone for an hour with anoying notifications but after that everything seems back to normal.
Thanks!

@timkrief
Copy link
Member

Hi all After upgrading, got to do the following to stop the faulty behavior : Airplane mode Clear the 2 way sync queue for all accounts Clear cache Revert Airplane mode

Hope it would help to solve things without uninstall and lose config.

Regards

I would love to do that, but it takes 1 min 30 sec to register one tap on a cross in the two way sync settings, and I have a crazy amount of folder listed there (my entire nextcloud data tree)

@kwisatz
Copy link
kwisatz commented Oct 27, 2024

Not only that.
This is what my Settings > Internal two way sync screen currently looks like in 3.30.2:
Image

@Tonus1
Copy link
Tonus1 commented Oct 27, 2024

@timkrief
@kwisatz
Go offline to get the app responsive

@kwisatz
Copy link
kwisatz commented Oct 27, 2024

@timkrief @kwisatz Go offline to get the app responsive

@Tonus1

The screen looks exactly the same for me with Airplane mode on.

@timkrief
Copy link
Member

@Tonus1 Thanks, unfortunately I'm already offline, going into the settings -> two way sync and removing one item in that list take roughly 1 minute each. I'm using a Galaxy S10. I tried on an other user's phone Galaxy S21 and the process is still really long (please add a button to remove everything in one tap, I have to use an autoclicker and I might have to wait for days) but there the app doesn't go unresponsive

See my detailed explanation here for more info: #13872 (comment)

@ltguillaume
Copy link
ltguillaume commented Oct 27, 2024

People, just call it a loss and reset the app.

Long-press Nextcloud, go into App info, open Storage & cache, press Clear storage and follow the instructions.
Then log in again, set up your automatic uploads again, double-check/adjust the contents of your On device via the drawer and be done with it.

@kwisatz
Copy link
kwisatz commented Oct 27, 2024

@ltguillaume the updates here are annoying me too… I'll just unsubscribe from the ticket now and just let this play out, and in a week or two I might retry.
I have uninstalled the app, I've cleared storage, I've cleared cache, the situation remains the same for me. I can supply more info to the devs if they tell me how, until then, signing off.

@ltguillaume
Copy link
ltguillaume commented Oct 27, 2024

@ltguillaume the updates here are annoying me too… I'll just unsubscribe from the ticket now and just let this play out, and in a week or two I might retry. I have uninstalled the app, I've cleared storage, I've cleared cache, the situation remains the same for me. I can supply more info to the devs if they tell me how, until then, signing off.

@kwisatz As far as I understand the problem, it is absolutely impossible to have the problem reappear after that (clearing storage or reinstalling): the issue occurs when updating to v3.30.1 only, not when installing v3.30.0 or any newer version.

@kwisatz
Copy link
kwisatz commented Oct 27, 2024

@ltguillaume we may be talking about a different issue… my issue is that the settings screen is simply black for me with 3.30.2. And the last time I checked, the app was happily continuing to shuffle data over my data connection. I just don't the have time to test and debug this.

@ltguillaume
Copy link

@kwisatz The Internal two way sync screen looks exactly the same for me and I have no clue how to even set up two way sync for a file or folder, if I ever wanted to. The context menu item Sync used to be a manual sync operation and it seems to still be that.

I just don't the have time to test and debug this.

Makes total sense.

@timkrief
Copy link
Member

People, just call it a loss and reset the app.

Or we could have a button to remove all two way syncs, and a button to diable two way syncs altogether

@stefan-muc
Copy link

Or we could have a button to remove all two way syncs, and a button to diable two way syncs altogether

See PR #13884, already in review and mentioned above in comment above

@sebeweiss
Copy link

@kwisatz @ltguillaume
For me it turns out, the two-way-sync page is completely empty (no buttons, nothing) if no folder is set up for syncing.
But if you have ticked ‘Synchronise’ for a folder under ‘Details’, this folder appears on that page.
So maybe you have ticked the 'Syncronise' checkbox for your folders...

@nextcloud nextcloud locked and limited conversation to collaborators Oct 28, 2024
@ZetaTom
Copy link
Collaborator
ZetaTom commented Oct 28, 2024

Dear Nextcloud Community,

As per my last message, we are currently investigating this issue and have released a new version that addresses the most critical problems present in version 3.30.1. We understand that these changes do not address all of the issues that our users have been experiencing. However, we will continue to work hard with our limited resources to find an appropriate solution for all users and are planning to release a new version later this week.

We take this incident very seriously and, in the interests of transparency and clarity, have published a report explaining what happened and how users can resolve these issues:

Many users are being directed to this thread via various search engines and trackers and are unaware of possible solutions and updates from us. In order to increase the visibility of our report and further raise awareness of the workarounds available to users, we have decided to lock this conversation until further notice. Please feel free to continue the discussion on the new ticket as well.

Finally, I would like to express my sincere gratitude to all the users and developers who have provided vital information and suggestions on this matter.

Thank you for your understanding and continued support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.