node: Mode system #853

Jim8y · 2022-04-03T01:49:19Z

updated to work under neo-project/neo-modules#709

This pr implements #863
Mode system is intended to help developers to save and load neo node configurations.

cli provides some default settings, such as mainnet, testnet, private net. Maybe Oracle net and FS net in the future.
user can load from these default settings.
user can have their own node setttings and save them as a mode
user can delete existing modes
if no mode is assigned from the console, load mainnet
Does not support runtime mode switch.

mainnet mode:

dotnet neo-cli.dll /mode mainnet

testnet mode:

dotnet neo-cli.dll /mode testnet

privatenet mode:

dotnet neo-cli.dll /mode privatenet

when user load into the privatenet mode, a single node blockchain network will be setup with the default primary account NbVj8GhwToNv4WF2gVaoco6hbkMQ8hrHWP. Please note that the secret key of this account is publicly available to everyone,

do not send any asset to this account in main net

you will lose your token and we will not be responsible for that.

Create your own mode
You can config your own network by modifying the config.json and config.fs.json in the root directory, as well as the config.json of Plugins. Then run mode save [mode name] to save your configuration as a mode. If the name you assigned is an existing mode, existing mode will be updated.

Your configurations will not be updated into mode automatically, you must manually run mode save [mode name] to save them.

Allow to flush the mempool in just 10 blocks.

* typo, comment, code optimization. * optimise code * Update ConsoleColorSet.cs * Update ConsoleColorSet.cs * revert all visiblities * revert change to visibility * remove null check and optimise code * remove null check * Revert some changes * Revert some changes * revert recursion * revert unnessary optimise * revert unnecessary optimise * revert almost all changes that has nothing to do witht typo * revert if statement changes * revert more unnesary optimise code * revert change to using packages order * revert change in wallet * Update neo-cli/CLI/MainService.Contracts.cs Co-authored-by: Shargon <shargon@gmail.com> * Update neo-cli/CLI/MainService.Contracts.cs Co-authored-by: Shargon <shargon@gmail.com> * Update Neo.ConsoleService/ConsoleServiceBase.cs * Update MainService.Node.cs * Update MainService.Node.cs * Update Logger.cs * remove default * remove static * remove static * remove token.cancel * Update MainService.Node.cs * Update MainService.Tools.cs Co-authored-by: Erik Zhang <erik@neo.org> Co-authored-by: Shargon <shargon@gmail.com>

neo-cli/Modes/Mode

erikzhang · 2022-04-08T02:44:43Z

neo-cli/Modes/privatenet/private.json

@@ -0,0 +1 @@
+{"name":null,"version":"1.0","scrypt":{"n":16384,"r":8,"p":8},"accounts":[{"address":"NbNRXrkfMyrEyEv2euE63Xxxqkno7xvuk2","label":null,"isDefault":false,"lock":false,"key":"","contract":{"script":"","parameters":[{"name":"signature","type":"Signature"}],"deployed":false},"extra":null}],"extra":null}


Why do we need this file?

anyone who want to setup a private single node network. such that they can start the private network without modifying anyting.

Without this given account, they will need to create an account by themself, then config the config.json manually.

But there is no private key in the wallet. The user still have to create another wallet.

Forgot that, will update right now.

We can not, they are of the same name~~~all of them are config.json

config.xxx.json?

emmmmmmmmm, good idea, will do.

config.json config.fs.json DBFTPlugin.json ApplicationLog.json under same folder now

They are still in different folders.

nicolegys · 2022-04-08T10:43:16Z

mode delete
Cannot delete a directory which is not empty.

save as an existing mode name
There is no warning and the original mode configs will be overwritten.

nicolegys · 2022-04-08T11:02:37Z

The logic of mode save is a little strange for me.
If I want to save a mode, firstly I need to start neo-cli with some specified mode in ./Mode/ folder or with default mode mainnet, and corresponding config files will be generated in ./ folder. Then I modify or replace the config files in ./ folder , use mode save <modeName> cmd to copy the config files to ./Mode/ folder. Why don't I directly create a new mode in ./Mode/ folder?:joy:

Jim8y · 2022-04-08T11:34:32Z

The logic of mode save is a little strange for me. If I want to save a mode, firstly I need to start neo-cli with some specified mode in ./Mode/ folder or with default mode mainnet, and corresponding config files will be generated in ./ folder. Then I modify or replace the config files in ./ folder , use mode save <modeName> cmd to copy the config files to ./Mode/ folder. Why don't I directly create a new mode in ./Mode/ folder?😂

Cause config.json are spread everywhere, with save mode we can collect config file from the node and Plugins. If user directly creates mode under Modes folder, how could they deal with Plugins.

neo-cli/Modes/privatenet/config.json

nicolegys · 2022-10-27T09:47:14Z

It uses an error plugin path when starting neo-cli in the different directory with neo-cli.dll.

Co-authored-by: Nicole <43694095+nicolegys@users.noreply.github.com>

Jim8y · 2022-10-27T14:27:37Z

It uses an error plugin path when starting neo-cli in the different directory with neo-cli.dll.

The path issue is not a problem should be addressed in this pr. it is a nature feature of C# on windows platform.

Relative path will always be relative to the executing folder, unless you publish it in a self-contain mode.

nicolegys · 2022-10-31T10:20:36Z

It uses an error plugin path when starting neo-cli in the different directory with neo-cli.dll.

The path issue is not a problem should be addressed in this pr. it is a nature feature of C# on windows platform.

Relative path will always be relative to the executing folder, unless you publish it in a self-contain mode.

It was published in the self-contain mode.
Actually, this issue is because method PluginExists uses the wrong path to find the specified plugin.

neo-cli/CLI/MainService.Plugins.cs

nicolegys · 2022-10-31T10:57:08Z

In addtion, as you said, relative path is an old issue that also exists in master branch, and it happens not only in the places I mentioned in this pr. I'll create annother issue if needed.

Jim8y · 2022-10-31T13:17:50Z

In addtion, as you said, relative path is an old issue that also exists in master branch, and it happens not only in the places I mentioned in this pr. I'll create annother issue if needed.

You dont have to, cause this issue does not exist in the official publish package as it is published in the self-contain mode.

Co-authored-by: Nicole <43694095+nicolegys@users.noreply.github.com>

nicolegys · 2022-11-01T06:38:47Z

In addtion, as you said, relative path is an old issue that also exists in master branch, and it happens not only in the places I mentioned in this pr. I'll create annother issue if needed.

You dont have to, cause this issue does not exist in the official publish package as it is published in the self-contain mode.

I have said that this issue also exists when it is published in the self-contain mode. I've tested it both on v3.4.0 and master branch, both on windows and linux. The cause of this issue is, in our code, files are read or generated based on the current execution directory, not the relative directory. And this issue was not raised before because of few usage scenarios, so it's not a high priority. Please be more careful.

superboyiii · 2022-11-18T08:44:05Z

@shargon Could you review again?

shargon · 2022-12-12T09:57:11Z

.github/workflows/test-neo-cli.expect

@@ -14,6 +14,10 @@ expect {
    timeout { exit 1 }
 }

+sleep 5


5 seconds is required?

Yes, has to wait for 5 seconds, at least

…de-system

superboyiii · 2023-02-02T06:15:27Z

@Liaojinghui Please solve conflicts

Jim8y · 2023-02-02T11:50:22Z

@Liaojinghui Please solve conflicts

Resolved

…de-system

roman-khimov and others added 7 commits February 10, 2022 17:51

neo-cli: tune MaxTransactionsPerBlock for testnet (neo-project#850)

d1bc7d1

Allow to flush the mempool in just 10 blocks.

set new network id for testnet

35269f6

revert

51b5514

Add new testnet network id (neo-project#852)

2ad44ef

create mode folders

8cac90f

privatenet config and commands

c9c3392

Jim8y marked this pull request as draft April 3, 2022 01:49

Jim8y mentioned this pull request Apr 6, 2022

node: ? ?? New Release - a Docker image, plz #824

Closed

Jim8y added 6 commits April 6, 2022 20:46

load mode

029ac42

list mode

d4bb9e4

delete mode

11dabc8

save mode

e86ab46

optimise code

c73623b

done with the mode system and added an icon for neo-cli

2564839

Jim8y marked this pull request as ready for review April 7, 2022 14:26

Jim8y added 2 commits April 7, 2022 10:38

fix format

cbd62b3

fix format....well, no idea where the format issue is

fd1ec20

erikzhang reviewed Apr 8, 2022

View reviewed changes

neo-cli/Modes/Mode Outdated Show resolved Hide resolved

remove mode file

7d5ed7f

erikzhang reviewed Apr 8, 2022

View reviewed changes

Jim8y added 5 commits April 7, 2022 23:08

update wallet file

6427f54

save config files in a same folder

01daf77

code optimise

8536ff9

fix logic

4f62c33

fix format

f41de1a

optimise code and solve delete issue

de3ccd8

nicolegys reviewed Oct 27, 2022

View reviewed changes

neo-cli/Modes/privatenet/config.json Outdated Show resolved Hide resolved

Jim8y and others added 3 commits October 27, 2022 08:53

Update neo-cli/Modes/privatenet/config.json

e12ad2d

Co-authored-by: Nicole <43694095+nicolegys@users.noreply.github.com>

Merge branch 'master' into mode-system

6cf1de2

Merge branch 'master' into mode-system

17e009c

nicolegys reviewed Oct 31, 2022

View reviewed changes

neo-cli/CLI/MainService.Plugins.cs Outdated Show resolved Hide resolved

nicolegys reviewed Oct 31, 2022

View reviewed changes

neo-cli/CLI/MainService.Plugins.cs Outdated Show resolved Hide resolved

Jim8y and others added 2 commits October 31, 2022 09:19

Update neo-cli/CLI/MainService.Plugins.cs

cb96042

Co-authored-by: Nicole <43694095+nicolegys@users.noreply.github.com>

Update neo-cli/CLI/MainService.Plugins.cs

858a922

Co-authored-by: Nicole <43694095+nicolegys@users.noreply.github.com>

Jim8y and others added 2 commits December 8, 2022 16:22

Merge branch 'master' into mode-system

9cdedc8

Update Helper.cs

305ab79

shargon reviewed Dec 12, 2022

View reviewed changes

superboyiii and others added 2 commits January 11, 2023 15:42

Merge branch 'master' into mode-system

c0cb778

Merge branch 'mode-system' of github.com:Liaojinghui/neo-node into mo…

456afc9

…de-system

Merge branch 'master' into mode-system

fc27b27

Jim8y and others added 5 commits February 2, 2023 06:50

Merge branch 'mode-system' of github.com:Liaojinghui/neo-node into mo…

374acf6

…de-system

update format

2e07919

Merge branch 'master' into mode-system

9445883

Merge branch 'master' into mode-system

892f2cd

Merge branch 'master' into mode-system

5faefae

shargon changed the title ~~Mode system~~ node: Mode system Dec 5, 2023

shargon added the node label Dec 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

node: Mode system #853

node: Mode system #853

		@@ -0,0 +1 @@
		{"name":null,"version":"1.0","scrypt":{"n":16384,"r":8,"p":8},"accounts":[{"address":"NbNRXrkfMyrEyEv2euE63Xxxqkno7xvuk2","label":null,"isDefault":false,"lock":false,"key":"","contract":{"script":"","parameters":[{"name":"signature","type":"Signature"}],"deployed":false},"extra":null}],"extra":null}

node: Mode system #853

Are you sure you want to change the base?

node: Mode system #853

Conversation

do not send any asset to this account in main net

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment