Building a project with Mono 5.16.0.179 crashes in the GenerateResource task #11663
Description
Users are reporting that building the Reko decompiler (https://github.com/uxmal/reko) on recent builds of mono is failing. More specifically, the resgen.exe tool is crashing during compilation of one of the .csproj projects. Users report crashing on Fedora, and I have reproduced the crash on Debian.
This was working fine in version 5.14.
Steps to Reproduce
- Have
mono-devel5.16.0.179 installed. I'm running this on a Debian VM under windows, but happens on bare-metal Fedora 29 as well. - Git clone the Reko sources from https://github.com/uxmal/reko
- Change directory to the source dir:
cd src - Start the build:
msbuild /p:Configuration=UnixRelease Reko-decompiler.sln
Current Behavior
When msbuild makes its way to the WindowsDecompiler.csproj project, it crashes with the following message
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: The "GenerateResource" task failed unexpectedly.
See uxmal/reko#715 for the detailed error output.
Expected Behavior
There should be no crash running this msbuild task. This is a regression from mono 5.14, where this issue is not present.
On which platforms did you notice this
[ ] macOS
[x] Linux (Debian 9.5, Fedora 29)
[ ] Windows
Version Used:
5.16.0.179
Stacktrace
CoreResGen:
/usr/lib/mono/4.5/resgen.exe /useSourcePath /r:/usr/lib/mono/4.7-api/Microsoft.CSharp.dll /r:REKO/external/Msagl/Microsoft.Msagl.dll /r:REKO/external/Msagl/Microsoft.Msagl.Drawing.dll /r:REKO/external/Msagl/Microsoft.Msagl.GraphViewerGdi.dll /r:/usr/lib/mono/4.7-api/mscorlib.dll /r:REKO/src/Core/bin/UnixRelease/Reko.Core.dll /r:REKO/src/Decompiler/bin/UnixRelease/Reko.dll /r:REKO/src/Gui/bin/UnixRelease/Reko.Gui.dll /r:/usr/lib/mono/4.7-api/System.Core.dll /r:/usr/lib/mono/4.7-api/System.Data.dll /r:/usr/lib/mono/4.7-api/System.dll /r:/usr/lib/mono/4.7-api/System.Drawing.dll /r:/usr/lib/mono/4.7-api/System.Net.Http.dll /r:/usr/lib/mono/4.7-api/System.Windows.Forms.dll /r:/usr/lib/mono/4.7-api/System.Xml.dll /r:/usr/lib/mono/4.7-api/System.Xml.Linq.dll /compile Controls/CombinedCodeView.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Controls.CombinedCodeView.resources Controls/DirtyManager.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Controls.DirtyManager.resources Controls/ImageMapControl.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Controls.ImageMapControl.resources Controls/ImageMapView.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Controls.ImageMapView.resources Controls/ImageSegmentView.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Controls.ImageSegmentView.resources Controls/LowLevelView.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Controls.LowLevelView.resources Controls/MemoryControl.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Controls.MemoryControl.resources Controls/TextView.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Controls.TextView.resources Forms/AboutDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.AboutDialog.resources Forms/AddressPromptDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.AddressPromptDialog.resources Forms/ArchiveBrowserDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.ArchiveBrowserDialog.resources Forms/AssembleFileDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.AssembleFileDialog.resources Forms/AssumedRegisterValuesDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.AssumedRegisterValuesDialog.resources Forms/CallSiteDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.CallSiteDialog.resources Forms/DeclarationForm.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.DeclarationForm.resources Forms/EditProjectDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.EditProjectDialog.resources Forms/EnvironmentSelectorDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.EnvironmentSelectorDialog.resources Forms/FindStringsDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.FindStringsDialog.resources Forms/JumpTableDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.JumpTableDialog.resources Forms/KeyBindingsDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.KeyBindingsDialog.resources Forms/MainForm.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.MainForm.resources Forms/OpenAsDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.OpenAsDialog.resources Forms/ProcedureDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.ProcedureDialog.resources Forms/ProgramPropertiesDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.ProgramPropertiesDialog.resources Forms/ResourceEditor.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.ResourceEditor.resources Forms/SearchDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.SearchDialog.resources Forms/SymbolSourceDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.SymbolSourceDialog.resources Forms/TextEncodingDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.TextEncodingDialog.resources Forms/UserPreferencesDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.UserPreferencesDialog.resources Forms/WorkerDialog.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Forms.WorkerDialog.resources Resources.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Resources.resources ViewImportsControl.resx,obj/Release/Reko.UserInterfaces.WindowsForms.ViewImportsControl.resources Resources.sv-SE.resx,obj/Release/Reko.UserInterfaces.WindowsForms.Resources.sv-SE.resources
Processing resource file "Controls/CombinedCodeView.resx" into "obj/Release/Reko.UserInterfaces.WindowsForms.Controls.CombinedCodeView.resources".
Processing resource file "Controls/DirtyManager.resx" into "obj/Release/Reko.UserInterfaces.WindowsForms.Controls.DirtyManager.resources".
Processing resource file "Controls/ImageMapControl.resx" into "obj/Release/Reko.UserInterfaces.WindowsForms.Controls.ImageMapControl.resources".
Processing resource file "Controls/ImageMapView.resx" into "obj/Release/Reko.UserInterfaces.WindowsForms.Controls.ImageMapView.resources".
Processing resource file "Controls/ImageSegmentView.resx" into "obj/Release/Reko.UserInterfaces.WindowsForms.Controls.ImageSegmentView.resources".
Processing resource file "Controls/LowLevelView.resx" into "obj/Release/Reko.UserInterfaces.WindowsForms.Controls.LowLevelView.resources".
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: The "GenerateResource" task failed unexpectedly. [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: System.NullReferenceException: Object reference not set to an instance of an object [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Text.EncoderReplacementFallback.GetHashCode () [0x00000] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Text.Encoding.GetHashCode () [0x0000c] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Collections.Hashtable.GetHash (System.Object key) [0x00015] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Collections.Hashtable.InitHash (System.Object key, System.Int32 hashsize, System.UInt32& seed, System.UInt32& incr) [0x00000] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Collections.Hashtable.get_Item (System.Object key) [0x0001a] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Runtime.Serialization.SerializationObjectManager.RegisterObject (System.Object obj) [0x00014] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Runtime.Serialization.Formatters.Binary.WriteObjectInfo.InitSerialize (System.Object obj, System.Runtime.Serialization.ISurrogateSelector surrogateSelector, System.Runtime.Serialization.StreamingContext context, System.Runtime.Serialization.Formatters.Binary.SerObjectInfoInit serObjectInfoInit, System.Runtime.Serialization.IFormatterConverter converter, System.Runtime.Serialization.Formatters.Binary.ObjectWriter objectWriter, System.Runtime.Serialization.SerializationBinder binder) [0x00061] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Runtime.Serialization.Formatters.Binary.WriteObjectInfo.Serialize (System.Object obj, System.Runtime.Serialization.ISurrogateSelector surrogateSelector, System.Runtime.Serialization.StreamingContext context, System.Runtime.Serialization.Formatters.Binary.SerObjectInfoInit serObjectInfoInit, System.Runtime.Serialization.IFormatterConverter converter, System.Runtime.Serialization.Formatters.Binary.ObjectWriter objectWriter, System.Runtime.Serialization.SerializationBinder binder) [0x00006] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.Serialize (System.Object graph, System.Runtime.Remoting.Messaging.Header[] inHeaders, System.Runtime.Serialization.Formatters.Binary.__BinaryWriter serWriter, System.Boolean fCheck) [0x0018b] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize (System.IO.Stream serializationStream, System.Object graph, System.Runtime.Remoting.Messaging.Header[] headers, System.Boolean fCheck) [0x0006e] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize (System.IO.Stream serializationStream, System.Object graph, System.Runtime.Remoting.Messaging.Header[] headers) [0x00000] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize (System.IO.Stream serializationStream, System.Object graph) [0x00000] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Resources.ResourceWriter.WriteValue (System.Resources.ResourceTypeCode typeCode, System.Object value, System.IO.BinaryWriter writer, System.Runtime.Serialization.IFormatter objFormatter) [0x0028d] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Resources.ResourceWriter.Generate () [0x00252] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Resources.ResourceWriter.Dispose (System.Boolean disposing) [0x0000b] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at System.Resources.ResourceWriter.Dispose () [0x00000] in <3d1438d9da1e4fe0b915f807d1ba56bd>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at Microsoft.Build.Tasks.ProcessResourceFiles.WriteResources (Microsoft.Build.Tasks.ProcessResourceFiles+ReaderInfo reader, System.Resources.IResourceWriter writer) [0x0005e] in <81c9ce198a7149a2865e2a88daae8111>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at Microsoft.Build.Tasks.ProcessResourceFiles.WriteResources (Microsoft.Build.Tasks.ProcessResourceFiles+ReaderInfo reader, System.String filename) [0x0005e] in <81c9ce198a7149a2865e2a88daae8111>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at Microsoft.Build.Tasks.ProcessResourceFiles.ProcessFile (System.String inFile, System.String outFileOrDir) [0x003f7] in <81c9ce198a7149a2865e2a88daae8111>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at Microsoft.Build.Tasks.ProcessResourceFiles.Run (Microsoft.Build.Utilities.TaskLoggingHelper log, Microsoft.Build.Framework.ITaskItem[] assemblyFilesList, System.Collections.Generic.List`1[T] inputs, System.Collections.Generic.List`1[T] satelliteInputs, System.Collections.Generic.List`1[T] outputs, System.Boolean sourcePath, System.String language, System.String namespacename, System.String resourcesNamespace, System.String filename, System.String classname, System.Boolean publicClass, System.Boolean extractingResWFiles, System.String resWOutputDirectory) [0x000fc] in <81c9ce198a7149a2865e2a88daae8111>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at (wrapper remoting-invoke-with-check) Microsoft.Build.Tasks.ProcessResourceFiles.Run(Microsoft.Build.Utilities.TaskLoggingHelper,Microsoft.Build.Framework.ITaskItem[],System.Collections.Generic.List`1<Microsoft.Build.Framework.ITaskItem>,System.Collections.Generic.List`1<Microsoft.Build.Framework.ITaskItem>,System.Collections.Generic.List`1<Microsoft.Build.Framework.ITaskItem>,bool,string,string,string,string,string,bool,bool,string) [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at Microsoft.Build.Tasks.GenerateResource.Execute () [0x0026a] in <81c9ce198a7149a2865e2a88daae8111>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00023] in <12215e3b02f24e078481ed2a7645c866>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
/usr/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(3066,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x001f6] in <12215e3b02f24e078481ed2a7645c866>:0 [REKO/src/UserInterfaces/WindowsForms/WindowsForms.csproj]
Let me know if I can be of assistance fixing this. I can be reached at https://gitter.im/uxmal/reko.