feat: Tower.async with rescuing for reporters #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzuy
commented
Mar 12, 2025
| rescue | ||
| exception -> | ||
| in_unlinked_task(fn -> | ||
| raise ReportEventError, |
There was a problem hiding this comment.
This now I realize doesn't make sense as is: raising an error called ReporEventError from a function that is called async. async function can be called from a reporter report_event, but any other place too.
lib/tower.ex
Outdated
| exception -> | ||
| in_unlinked_task(fn -> | ||
| raise ReportEventError, | ||
| reporter: reporter_from_stacktrace(__STACKTRACE__), |
There was a problem hiding this comment.
The calculated reporter module from this function might not match the configured reporter if the Tower.async in the reporter was called from a internal module or error raised from internal module.
Which means in those cases, there will be a infinite loop because the :ignore function clause will not match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.