Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up from "Resolve "Make setting-level env: declaration a one-way injection into the plugin execution context"" #3454

Open
3 tasks
MeltyBot opened this issue May 27, 2022 · 2 comments

Comments

@MeltyBot
Copy link
Contributor
MeltyBot commented May 27, 2022

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3540

Originally created by @aaronsteers on 2022-05-27 15:38:12


The following discussions from !2645 should be addressed:

  • @aaronsteers started a discussion:

    If the below is true, what do you think of the following update?

        - name: setting_name # Required. Within the plugin's execution context, this will generate an environment variable with the naming convention `<PLUGIN_NAME>_<SETTING_NAME>`.
    

    (Non-blocking. Okay to move this into a follow-on issue.)

  • @aaronsteers started a discussion:

          value: "" # Optional default value to use if no other value is set.
    
  • @aaronsteers started a discussion:

          env: SOME_API_KEY # Optional (use to inject `value` into plugin context with a custom environment variable name, in addition to the default `<PLUGIN_NAME>_<SETTING_NAME>` env var)
    
@MeltyBot
Copy link
Contributor Author

@stale
Copy link
stale bot commented Apr 26, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Apr 26, 2023
@tayloramurphy tayloramurphy added the evergreen Never stale label Apr 26, 2023
@stale stale bot removed the stale label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants