Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds fork-transaction-hash and rename network to fork-url #431

Merged
merged 5 commits into from
Nov 26, 2024
Merged

feat: adds fork-transaction-hash and rename network to fork-url #431

merged 5 commits into from
Nov 26, 2024

Conversation

dutterbutter
Copy link
Collaborator
@dutterbutter dutterbutter commented Nov 25, 2024 •
edited
Loading

What 💻

  • adds fork-transaction-hash
  • rename network to fork-url
  • adds update methods for fork configuration to TestNodeConfig impl

Why ✋

  • Anvil CLI parity

Evidence 📷

Usage:

./target/release/era_test_node fork --fork-url mainnet --fork-transaction-hash 0xd92d802ba395e3e6db0c6def7f88e5828aa466118dc87d3b96a9fef718b851d5

@dutterbutter dutterbutter requested a review from a team as a code owner November 25, 2024 20:38
@dutterbutter dutterbutter added the needs review 👓 PR requires a review label Nov 25, 2024
itegulov
itegulov reviewed Nov 25, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@dutterbutter dutterbutter merged commit 4a99b85 into main Nov 26, 2024
12 checks passed
@dutterbutter dutterbutter deleted the db/fork-cli-parity branch November 26, 2024 12:54
itegulov pushed a commit that referenced this pull request Nov 27, 2024
@dutterbutter @itegulov
feat: adds fork-transaction-hash and rename network to fork-url (…
e9b74a4 
…#431)

* feat: refactor network cli param for fork_url

* chore: clean up

* feat: add fork-from-transaction-hash

* refactor: add helper methods to config impl for fork config updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

@itegulov itegulov itegulov approved these changes

Assignees
No one assigned
Labels
needs review 👓 PR requires a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dutterbutter @itegulov @popzxc