Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to convert MassActionJumps to ConstantRateJumps #427

Open
isaacsas opened this issue Jun 14, 2024 · 3 comments
Open

add option to convert MassActionJumps to ConstantRateJumps #427

isaacsas opened this issue Jun 14, 2024 · 3 comments

Comments

@isaacsas
Copy link
Member

In some preliminary benchmarking for a talk I'm finding that when using Direct with a small number of jumps (~6), we can actually now get a ~30% speedup using ConstantRateJumps. This needs more investigation, but it may be that in the case of a small number of jumps, where we don't need function wrappers and use recursion for type-stability, we can now do better than MassActionJumps.
@isaacsas
Copy link
Member Author

(This is also consistent with the performance difference between MassActionJumps and a hand-coded Direct method that evaluates propensities via a single function.)

@ChrisRackauckas
Copy link
Member

That is rather surprising still, but interesting.

@isaacsas
Copy link
Member Author
isaacsas commented Jun 14, 2024 •
edited
Loading

Yeah, I'm not yet convinced of this result, but the conversion would be easy to add and allow us to test this systematically from Catalyst-generated models in SciMLBenchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @isaacsas