Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Project Descriptions #2757

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Feat: Add Project Descriptions #2757

wants to merge 6 commits into from
+612 −413

Conversation

McPizza0
Copy link
Contributor
@McPizza0 McPizza0 commented Nov 19, 2024 •
edited
Loading

Description 📣

Adds the ability to set a Project description when creating a new project, or editing an existing one

Creating:
image

Display:
image

Editing:
image

Video:

Screen.Recording.2024-11-20.at.3.31.29.PM.mov

Misc:

  • refactored "New Project Modal" from into one single shared component across app
  • switched from yup to zod for schema validations in touched areas
  • Fixed type check issues from other PR - 4004bd2

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

Manual Testing

@McPizza0 McPizza0 changed the title Omar/eng 1574 projects need a description section Feat: Add Project Descriptions Nov 19, 2024
@DanielHougaard DanielHougaard marked this pull request as ready for review November 20, 2024 13:23
@McPizza0 McPizza0 force-pushed the omar/eng-1574-projects-need-a-description-section branch from 25bd1cd to 078ce21 Compare November 20, 2024 13:35
@McPizza0 McPizza0 marked this pull request as draft November 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielHougaard DanielHougaard Awaiting requested review from DanielHougaard

@vmatsiiako vmatsiiako Awaiting requested review from vmatsiiako

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@McPizza0