-
Notifications
You must be signed in to change notification settings - Fork 22
Closed
Description
Hi Lucia,
I wanted to point out some errors I had while deploying the dags in a 1.20.5 composer instance running Airflow 2.4.3:
- “f{api_name}id”.lower() should be f"{api_name}id".lower() inside line 92 in cdc_dag_generator/generate_dags.py
- In the generated CDC dags, the import “from airflow.models.dag import DagRun, State, DagBag.” throws an error in Composer. Fixed by importing DagBag from airflow.models.dagbag separately;
- In the CDC dag template, we call datetime.utcnow() with datetime imported from pendulum. This method apparently does not exist. Can be fixed by importing “now” from pendulum (this func should be renamed since we then create a variable called now as well) and changing line 48 in cdc_dag_generator/templates/airflow_dag_raw_to_cdc.py with now = now(tz='UTC').
Best regards,
Marco.