[WIP] Catalyst support #3235
[WIP] Catalyst support #3235
Conversation
This `enum` isn't expected to change. It's important to mark it as `@frozen` so that clients don't get warnings whem compiling with `BUILD_LIBRARY_FOR_DISTRIBUTION`, which might be required in a future version of Carthage supporting Catalyst. (See Carthage/Carthage#3235).
This `enum` isn't expected to change. It's important to mark it as `@frozen` so that clients don't get warnings whem compiling with `BUILD_LIBRARY_FOR_DISTRIBUTION`, which might be required in a future version of Carthage supporting Catalyst. (See Carthage/Carthage#3235).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Disregard that linking issue, that was the same as ReactiveCocoa/ReactiveSwift#809. So bottomline, I can confirm this branch works fine, pending the remaining TODOs. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Thanks bot but I do want to finish this and merge it since I'm currently using it for my app. |
This fixes compilation on Xcode 14. Bitcode is going awaym so `ENABLE_BITCODE` defaults to `NO` now.
|
For anyone using this, it works well on Xcode 14 (especially after my last commit) |
| public var destination: String? { | ||
| switch (self.rawValue, self.variant) { | ||
| case (_, .macCatalyst?): return "generic/platform=macOS,variant=Mac Catalyst" | ||
| case ("macos", _): return "generic/platform=macOS" |
There was a problem hiding this comment.
This is causing an error later when building for macOS
CarthageKit/Xcode.swift:1046: Fatal error: Unexpectedly found nil while unwrapping an Optional value
I believe it should be:
| case ("macos", _): return "generic/platform=macOS" | |
| case ("macosx", _): return "generic/platform=macOS" |
There was a problem hiding this comment.
Works for me otherwise, and solves my issue (see getsentry/sentry-cocoa#2031)
Will be great to see this merged in. Thanks for you hard work!
|
This will really help us at with the cocoa SDK and building for .NET MAUI 👍 |
|
Any update on this? |
Fixes #2799
This PR adds support for a new
--platformmacCatalystwhen building with--use-xcframeworks.Important: this is still a draft and not ready for production, but it does work. Feel free to check out the branch and
make installit if you want to test it out.The code isn't really worth reviewing at the moment. Its current state is more of a proof of concept, and the current implementation likely breaks under some scenarios. However, I was able to build my entire app (Watch Chess) with it for
iOS,tvOS,watchOS, andmacCatalyst.Notes:
build/archivebased on what's being built. Instead, this now uses "generic" destinations, which seem to provide a more deterministic and simpler approach.--use-xcframeworks.BUILD_LIBRARY_FOR_DISTRIBUTION, which seems to be required now (see also https://pspdfkit.com/blog/2020/supporting-xcframeworks/)TODO:
BCSymbolMapsmacCatalyst"slice" for a target withoutSUPPORTS_MACCATALYSTset toYES. Right now it just fails to compile without a clear error.--platform macCatalystwithout--use-xcframeworks, as that's not supported by Xcode.