-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection: Should Client Error be logged as debug instead of error? #1080
Comments
Asking for a folder that doesn't exist results in a 4XX http code. Do you have the complete http code returned when a folder doesn't exist? maybe something can be donde there, but if it's too generic I don't think I can change the log to debug. |
Could be a solution, but I could see while you'd be hesitant. If you decide against it I can always exclude o365 from the root logger. |
400 is extremely generic... While I can certainly do what you paste you can see the snowball effect this can have. Let me think about it. |
In case this changes your decision: while creating pr #1081 I noticed that the client error isn't actually
I got |
Hi,
I am using
drive.get_item_by_path()
to check which files a folder contains, if any.If a folder doesn't exist I consider it to be empty.
The issue is that
connection.py
(line 838) logs the exception. Since there is a use-case where this is the intended behaviour and not actually an unexpected error would you be open to reducing the log-level to debug?The text was updated successfully, but these errors were encountered: