Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Protocol not provided to Api Component" when copying files from a shared OneDrive #1048

Open
jkunczik opened this issue Jan 25, 2024 · 3 comments
Open

"Protocol not provided to Api Component" when copying files from a shared OneDrive #1048

jkunczik opened this issue Jan 25, 2024 · 3 comments

Comments

@jkunczik
Copy link
jkunczik commented Jan 25, 2024 •
edited
Loading

I have a problem copying files in a shared OneDrive.

Error Description

When attempting to copy files from one directory to another in a shared OneDrive using the following Python code:

operation = item.copy(target=dest_folder, name=new_name)

The following error is encountered:

  File "...\miniconda3\envs\Automations\Lib\site-packages\O365\drive.py", line 153, in __init__
    super().__init__(
  File "...\miniconda3\envs\Automations\Lib\site-packages\O365\utils\utils.py", line 344, in __init__
    raise ValueError('Protocol not provided to Api Component')

It is worth noting that despite the error, the copy operation still succeeds.

Steps to Reproduce

  1. Attempt to copy a DriveItem from a shared OneDrive using the provided code snippet.

Origin of the Error

Upon inspecting the source code, it was discovered that the protocol is set within the CopyOperation class:

class CopyOperation(ApiComponent):
    ...
    def __init__(self, *, parent=None, con=None, **kwargs):
    ...
    super().__init__(
            protocol=parent.protocol if parent else kwargs.get('protocol'),
            main_resource=main_resource)
    ...

This is invoked from the DriveItem.copy() method with the arguments CopyOperation(parent=self.drive, ...). Further investigation revealed that self.drive is set to None.

Workaround

A temporary workaround for this issue is to wrap the copy statement in a try/except block.

Question

Is there a more elegant solution to address this problem?
@alejcas
Copy link
Member
alejcas commented Feb 1, 2024

This makes no sense.

In order for CopyOperation to work, it needs a connection object. The connections objects comes directly from the parent attribute (or con if provided but it's not provided from driveitem.copy):

python-o365/O365/drive.py

Line 148 in 417d8cf

self.con = parent.con if parent else con

So parent can't be None or otherwise the connection will be None and the whole copy operation becomes impossible.

Are you sure self.drive is None from the driveitem that executes the copy method?

This must be something else.

@jkunczik
Copy link
Author
jkunczik commented Feb 4, 2024

First of all: Thank you so much for your time and the effort you put into this project! It is really appreciated.

I think drive.copy does not use the parent, but self.drive instead:

python-o365/O365/drive.py

Line 790 in 417d8cf

return CopyOperation(parent=self.drive, monitor_url=location, target=target_drive)

The latter one is None in case of a shared folder (at least for me):

grafik

Maybe the connection object is taken from the parent, but the protocol information is taken from self.drive which is denoted parent in the failing method?

@alejcas
Copy link
Member
alejcas commented Feb 28, 2024

Can you provide the code on how you get the shared driveitem please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alejcas @jkunczik