⚙ D200409 Bug 1805727 - Part 2: Add transition-behavior to transition shorthand in style.

only style (wip)

Herald added a project: secure-revision. · View Herald TranscriptFeb 2 2024, 3:06 AM

Harbormaster completed remote builds in B622872: Diff 817205.Feb 2 2024, 3:06 AM

boris added a child revision: D200410: Bug 1878758 - Follow shortest serialization principle for transition shorthand..Feb 2 2024, 3:06 AM

phab-bot published this revision for review.Feb 2 2024, 3:06 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added subscribers: zrhoffman, emilio. · View Herald TranscriptFeb 2 2024, 3:06 AM

Code analysis found 1 defect in diff 817205:

1 defect found by eslint (Mozlint)

IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 817205.

boris removed a child revision: D200410: Bug 1878758 - Follow shortest serialization principle for transition shorthand..Feb 5 2024, 9:02 PM

boris updated this revision to Diff 823309.Feb 14 2024, 8:22 PM

boris added a child revision: D201863: Bug 1805727 - Part 3: Rename all-with-discrete.tentative.html..

Harbormaster completed remote builds in B628023: Diff 823309.Feb 14 2024, 8:22 PM

boris added reviewers: layout-reviewers, Restricted Project.Feb 14 2024, 10:05 PM

emilio accepted this revision.Feb 19 2024, 10:47 AM

emilio added a project: testing-approved.

emilio added inline comments.

layout/inspector/tests/test_bug877690.html
149	You are enabling the pref unconditionally in the manifest, so probably just remove this condition and inline it?

This revision is now accepted and ready to land.Feb 19 2024, 10:47 AM

Addressed comments

Harbormaster completed remote builds in B629830: Diff 825467.Feb 21 2024, 9:45 PM

boris removed reviewers: layout-reviewers, Restricted Project.Feb 23 2024, 9:23 PM

Addressed comments

Harbormaster completed remote builds in B630856: Diff 826708.Feb 23 2024, 9:24 PM

Rebased

Harbormaster completed remote builds in B630877: Diff 826742.Feb 23 2024, 9:41 PM

Closed by commit rMOZILLACENTRALea25a67b45f8: Bug 1805727 - Part 2: Add transition-behavior to transition shorthand in style. (authored by boris). · Explain WhyFeb 23 2024, 9:48 PM

This revision was automatically updated to reflect the committed changes.

boris added a commit: rMOZILLACENTRALea25a67b45f8: Bug 1805727 - Part 2: Add transition-behavior to transition shorthand in style..

Harbormaster completed remote builds in B631029: Diff 826755.Feb 27 2024, 1:24 AM

Bug 1805727 - Part 2: Add transition-behavior to transition shorthand in style.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 826755

layout/inspector/tests/mochitest.toml

layout/inspector/tests/test_bug877690.html

layout/style/test/property_database.js

layout/style/test/test_shorthand_property_getters.html

servo/components/style/properties/shorthands/ui.mako.rs

servo/components/style/values/specified/animation.rs

testing/web-platform/meta/css/css-transitions/parsing/transition-behavior.html.ini

testing/web-platform/meta/css/css-transitions/parsing/transition-shorthand.html.ini

Bug 1805727 - Part 2: Add transition-behavior to transition shorthand in style.ClosedPublicActions