Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

WIP: for Bug 1833244. Support `page-orientation` rotation on PrintedSheetFrame for pages-per-sheet==1
AbandonedPublicDraft

Authored by jwatt on May 18 2023, 1:21 PM.

Details

Reviewers
None
Bugzilla Bug ID
1833244
Summary

I'm just putting this up to make it available for the curious. This doesn't
actually build right now since I haven't fixed it up yet after moving bits of
the code to earlier patches that I'm actively working on to make reviews
easier.

Depends on D178440

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default
Lint
No Lint Coverage
SeverityLocationCodeMessage
Errordocshell/base/nsDocShellLoadState.h:27clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadState.h:42clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadState.h:50clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadState.h:345clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:43clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:46clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:51clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:53clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:63clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:68clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:70clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:77clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:85clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:89clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:91clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:94clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:97clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:100clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:109clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:114clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:124clang-diagnostic-errorBuild Error
Errordocshell/base/nsDocShellLoadTypes.h:154clang-diagnostic-errorBuild Error
Warninglayout/generic/PrintedSheetFrame.cpp:56readability-qualified-autoclang-tidy
Warninglayout/generic/nsPageSequenceFrame.cpp:358invalid-stylingclang-format
Warninglayout/generic/nsPageSequenceFrame.cpp:364source-test-mozlint-clang-formatclang-format (Mozlint)
Unit
No Test Coverage

Unit TestsUnsound

TimeTest
0 mscode-review::mercurial
WARNING: The base revision of your patch is not available in the current repository. Your patch has been rebased on central (revision 178441): issues may be positioned on the wrong lines.

Event Timeline

jwatt created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".May 18 2023, 1:22 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 2281 defects (2277 in a parent revision) in the diff 718452:

  • 1 defect found by clang-format
  • 1 defect found by clang-format (Mozlint)
  • 2278 build errors and 1 defect found by clang-tidy
WARNING: Found 3 issues (warning level) that can be dismissed.
IMPORTANT: Found 2278 issues (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach clang-format -p layout/generic/nsPageSequenceFrame.cpp
  • ./mach lint --warnings --outgoing
  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).


If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 718452.