Bug 1815975 - Introduce the start offset and the end offset for computing the progress of ScrollTimeline.
AbandonedPublic
Actions

Authored by boris on Feb 9 2023, 9:09 PM.

Details

Reviewers

hiro

Group Reviewers

layout-reviewers

Bugzilla Bug ID

1737920

Summary

So it'd be easier to introduce view timelines by overriding ComputeOffsets().

Basically, we use offsets to control the animation progress.
For scroll-timeline, it's simply 0 to the scroll range.
For view-timeline, its progress is between 0% and 100% if the subject element
is in the view. Otherwise, its progress is outside the range. We will
implement the offset calculation of view-timeline in Bug 1737920.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Branch

HEAD

Lint

No Lint Coverage

Unit

No Test Coverage

Unit TestsFailed
View All

Time

Test

38,451 ms

code-review::mercurial

WARNING: The code review bot failed to apply your patch because the parent revision (d11def649405c152c0e01861d1a53c0af3441b11) does not exist on mozilla-unified. If possible, you should publish that revision.

patching file dom/animation/ScrollTimeline.h
Hunk #1 succeeded at 181 with fuzz 1 (offset -7 lines).
patching file dom/animation/ScrollTimeline.cpp
Hunk #2 FAILED at 174
1 out of 2 hunks FAILED -- saving rejects to file dom/animation/ScrollTimeline.cpp.rej
abort: patch failed to apply