Details
- Reviewers
AlaskanEmily - Bugzilla Bug ID
- 1673987
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Branch
- default
- Lint
No Lint Coverage - Unit
No Test Coverage
Time | Test | |
---|---|---|
0 ms | code-review::mercurial WARNING: The base revision of your patch is not available in the current repository.
Your patch has been rebased on central (revision 169341): issues may be positioned on the wrong lines. |
Event Timeline
layout/generic/nsPageFrame.cpp | ||
---|---|---|
553 | Reflow has happened by this point, so there's no need to null check GetSharedPageData()(). (There are loads of places that just use mPD unchecked in nsPageFrame on that basis.) | |
573 | Sooo...obviously this is all a bit silly, undoing various steps that we carried out earlier. However, I tied myself up in knots a bit trying to refactor the code to avoid that. I'll come back to that and have another pass at it later, but for now everyone (including yourself, I'm sure) wants to just see a working implementation go out the door. The code changes are much more straightforward to follow this way, and lower risk which seems important if landing at code freeze time. This way it's also pretty easy to put all changed code behind the pref, making it easy to turn off if things go wrong, which again seems desirable. | |
589 | Let me know if I need to expand this comment a bit. It is perhaps not too obvious what I'm doing in the following lines of code, but maybe it is? |
Code analysis found 4 defects in the diff 679253:
- 4 defects found by clang-tidy
You can run this analysis locally with:
- ./mach static-analysis check --outgoing (C/C++)
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 679253.
Code analysis found 4 defects in the diff 679253:
- 4 defects found by clang-tidy
You can run this analysis locally with:
- ./mach static-analysis check --outgoing (C/C++)
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 679253.