Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

WIP: Bug 1740530 - Implement variation-enabled versions of paint tables.
AbandonedPublicDraft

Authored by jfkthame on Jul 28 2022, 11:18 AM.

Details

Reviewers
None
Bugzilla Bug ID
1740530

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default
Lint
No Lint Coverage
Unit
No Test Coverage

Unit TestsFailed

TimeTest
31,572 mscode-review::mercurial
WARNING: The code review bot failed to apply your patch.
patching file gfx/thebes/COLRFonts.cpp
Hunk #1 FAILED at 33
Hunk #2 FAILED at 282
2 out of 2 hunks FAILED -- saving rejects to file gfx/thebes/COLRFonts.cpp.rej
abort: patch failed to apply

Event Timeline

jfkthame created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Jul 28 2022, 11:19 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 42 defects in the diff 607819:

  • 1 build error and 41 defects found by clang-tidy
WARNING: Found 41 issues (warning level) that can be dismissed.
IMPORTANT: Found 1 issue (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 607819.

jfkthame edited the summary of this revision. (Show Details)

Code analysis found 42 defects in the diff 607893:

  • 1 build error and 41 defects found by clang-tidy
WARNING: Found 41 issues (warning level) that can be dismissed.
IMPORTANT: Found 1 issue (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 607893.