Differential D130661

Bug 502258 - Simplify implementation of "show password" / "clear" button. r=mats
AbandonedPublic
Actions

Authored by emilio on Nov 8 2021, 4:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jul 10 2024, 7:04 PM

	Unknown Object (File)
	Jun 15 2024, 6:59 AM

	Unknown Object (File)
	Jun 11 2024, 11:46 PM

	Unknown Object (File)
	Jun 2 2024, 7:05 AM

Subscribers

Details

Reviewers

Bugzilla Bug ID

Summary

I think this is nicer, should persist the state across reframes, and is
less special.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Branch

default

Lint

No Lint Coverage

Unit

No Test Coverage

Unit TestsFailed
View All

Time

Test

21,886 ms

code-review::mercurial

WARNING: The code review bot failed to apply your patch.

patching file layout/style/res/forms.css
Hunk #1 FAILED at 183
1 out of 3 hunks FAILED -- saving rejects to file layout/style/res/forms.css.rej
patching file layout/forms/nsTextControlFrame.h
Hunk #1 FAILED at 228
Hunk #2 FAILED at 387
2 out of 2 hunks FAILED -- saving rejects to file layout/forms/nsTextControlFrame.h.rej
patching file layout/forms/nsTextControlFrame.cpp
Hunk #1 FAILED at 394
Hunk #2 FAILED at 461
Hunk #3 FAILED at 575
Hunk #4 FAILED at 1286
4 out of 4 hunks FAILED -- saving rejects to file layout/forms/nsTextControlFrame.cpp.rej
patching file dom/html/HTMLInputElement.cpp
Hunk #1 FAILED at 4003
Hunk #4 FAILED at 6680
Hunk #5 FAILED at 6720
3 out of 5 hunks FAILED -- saving rejects to file dom/html/HTMLInputElement.cpp.rej
patching file dom/base/CharacterData.h
Hunk #1 FAILED at 88
1 out of 1 hunks FAILED -- saving rejects to file dom/base/CharacterData.h.rej
abort: patch failed to apply

Event Timeline

emilio created this revision.Nov 8 2021, 4:52 PM

Herald added a project: secure-revision. · View Herald TranscriptNov 8 2021, 4:52 PM

Harbormaster completed remote builds in B369998: Diff 505699.Nov 8 2021, 4:52 PM

emilio added a child revision: D130662: Bug 502258 - part 2 - Implement "Toggle show password" context menu correctly. r=mats!,Gijs!.Nov 8 2021, 4:52 PM

phab-bot published this revision for review.Nov 8 2021, 4:52 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

emilio mentioned this in D130407: Bug 502258 - Add a Show Password button to <input type=password> controls. r=emilio,mats.Nov 13 2021, 12:35 PM

Itiel added a subscriber: Itiel.Nov 13 2021, 4:10 PM

emilio abandoned this revision.Nov 15 2021, 6:45 PM

emilio removed a child revision: D130662: Bug 502258 - part 2 - Implement "Toggle show password" context menu correctly. r=mats!,Gijs!.

emilio added a child revision: D130662: Bug 502258 - part 2 - Implement "Toggle show password" context menu correctly. r=mats!,Gijs!.Nov 15 2021, 7:26 PM

Revision Contents
Changeset List

Path

Size

dom/

base/

CharacterData.h

8 lines

events/

6 lines

html/

HTMLInputElement.h

5 lines

HTMLInputElement.cpp

69 lines

layout/

base/

RestyleManager.cpp

6 lines

forms/

nsSearchControlFrame.cpp

25 lines

nsTextControlFrame.h

17 lines

nsTextControlFrame.cpp

56 lines

generic/

nsTextFrame.cpp

9 lines

style/

res/

36 lines

servo/

components/

style/

element_state.rs

5 lines

gecko/

non_ts_pseudo_class_list.rs

2 lines

4 lines

Diff 505699

dom/base/CharacterData.h

Loading...

dom/events/EventStates.h

Loading...

dom/html/HTMLInputElement.h

Loading...

dom/html/HTMLInputElement.cpp

Loading...

layout/base/RestyleManager.cpp

Loading...

layout/forms/nsSearchControlFrame.cpp

Loading...

layout/forms/nsTextControlFrame.h

Loading...

layout/forms/nsTextControlFrame.cpp

Loading...

layout/generic/nsTextFrame.cpp

Loading...

layout/style/res/forms.css

Loading...

servo/components/style/element_state.rs

Loading...

servo/components/style/gecko/non_ts_pseudo_class_list.rs

Loading...

servo/components/style/gecko/wrapper.rs

Loading...