Details

boris retitled this revision from Bug 1676791 - Part 4: Prevent getAnimations(). to Bug 1676791 - Part 4: Prevent getAnimations() from returning scroll-linked animations..

Harbormaster completed remote builds in B364866: Diff 499012.Oct 21 2021, 2:05 AM

phab-bot published this revision for review.Oct 21 2021, 2:05 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Fix crash, wpt, and add more reftests

Harbormaster completed remote builds in B365993: Diff 500529.Oct 25 2021, 9:17 PM

Update documentation of fix some clang-formats

boris edited the summary of this revision. (Show Details)Oct 27 2021, 1:38 AM

Harbormaster completed remote builds in B366527: Diff 501164.Oct 27 2021, 1:38 AM

boris added a reviewer: Restricted Project.Oct 27 2021, 6:03 AM

Oh okay, here's a usage of AnimationTimeline::TimelineType.

Is there any test case for this?

This revision is now accepted and ready to land.Oct 27 2021, 6:37 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Address comments

Harbormaster completed remote builds in B370053: Diff 505792.Nov 8 2021, 8:04 PM

Address comments

boris retitled this revision from Bug 1676791 - Part 4: Prevent getAnimations() from returning scroll-linked animations. to Bug 1676791 - Part 5: Prevent getAnimations() from returning scroll-linked animations..Nov 15 2021, 8:32 PM

boris edited parent revisions, added: D131168: Bug 1676791 - Part 5: Define the finite timeline and use it in Play() and Pause().; removed: D129101: Bug 1676791 - Part 3: Implement the computation of timing..

Harbormaster completed remote builds in B371934: Diff 508053.Nov 15 2021, 8:32 PM

In D129102#4211714, @hiro wrote:

Oh okay, here's a usage of AnimationTimeline::TimelineType.

Is there any test case for this?

Now we use IsScrollTimeline() and this is also used in previous patches.

Rearrange

Harbormaster completed remote builds in B372938: Diff 509287.Nov 18 2021, 12:06 AM

boris retitled this revision from Bug 1676791 - Part 5: Prevent getAnimations() from returning scroll-linked animations. to Bug 1676791 - Part 6: Prevent getAnimations() from returning scroll-linked animations..Nov 18 2021, 12:06 AM

Note that this change also needs a test, if this didn't work as expected, it will probably result crashes, that's we want to avoid.

boris removed a reviewer: Restricted Project.Nov 18 2021, 11:13 PM

Address final comments and rebased

Harbormaster completed remote builds in B376870: Diff 513974.Nov 30 2021, 7:46 PM

Rebased

Harbormaster completed remote builds in B379046: Diff 516530.Dec 7 2021, 9:04 PM

In D129102#4273878, @hiro wrote:

Note that this change also needs a test, if this didn't work as expected, it will probably result crashes, that's we want to avoid.

@boris Did you add any tests for getAnimations()? I'd expect two test cases, one is getAnimations on an element having an CSS animation and a scroll linked animations, one is getAnimations for a document. Thanks!

In D129102#4331217, @hiro wrote:

In D129102#4273878, @hiro wrote:

Note that this change also needs a test, if this didn't work as expected, it will probably result crashes, that's we want to avoid.

@boris Did you add any tests for getAnimations()? I'd expect two test cases, one is getAnimations on an element having an CSS animation and a scroll linked animations, one is getAnimations for a document. Thanks!

Good catch! Doing now

Add tests

Harbormaster completed remote builds in B379092: Diff 516562.Dec 7 2021, 11:00 PM

Thanks! A very minor nit about the test, it would be nice to scroll the root scroller and call getComputedStyle to make sure the scroll linked animation should be there.

Fix tests

Harbormaster completed remote builds in B379102: Diff 516572.Dec 7 2021, 11:29 PM

The test will be move into part 8 because we don't hook CSS animation to scroll-timeline at this moment. I will move the test before landing

Move test and ready to land

Harbormaster completed remote builds in B379158: Diff 516650.Dec 8 2021, 1:14 AM