So we don't expose scroll-linked animations to script.
Details
- Reviewers
hiro - Commits
- Restricted Diffusion Commit
rMOZILLACENTRALd5a68dd4b920: Bug 1676791 - Part 6: Prevent getAnimations() from returning scroll-linked… - Bugzilla Bug ID
- 1676791
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Lint Not Applicable - Unit
Tests Not Applicable - Build Status
Buildable 379385 Build 474222: arc lint + arc unit
Event Timeline
Oh okay, here's a usage of AnimationTimeline::TimelineType.
Is there any test case for this?
This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!
Note that this change also needs a test, if this didn't work as expected, it will probably result crashes, that's we want to avoid.
@boris Did you add any tests for getAnimations()? I'd expect two test cases, one is getAnimations on an element having an CSS animation and a scroll linked animations, one is getAnimations for a document. Thanks!
Thanks! A very minor nit about the test, it would be nice to scroll the root scroller and call getComputedStyle to make sure the scroll linked animation should be there.
The test will be move into part 8 because we don't hook CSS animation to scroll-timeline at this moment. I will move the test before landing