Nothing Special   »   [go: up one dir, main page]
Page MenuHomePhabricator
Differential D113198

Bug 1312588 - Part 4: Replace eWidthProperty with the enum class, SizeProperty.
ClosedPublic
Actions

Authored by boris on Apr 22 2021, 11:22 PM.

Details

Reviewers
emilio
Group Reviewers
layout-reviewers
Commits
rMOZILLACENTRALf0de4933e215: Bug 1312588 - Part 4: Replace eWidthProperty with the enum class, SizeProperty.
Bugzilla Bug ID
1312588

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 327175
Build 421172: arc lint + arc unit

Event Timeline

boris created this revision.Apr 22 2021, 11:22 PM
Herald added a project: secure-revision. · View Herald TranscriptApr 22 2021, 11:22 PM
boris added a child revision: D113199: Bug 1312588 - Part 5: Implement the intrinsic size contribution for fit-content()..Apr 22 2021, 11:22 PM
Harbormaster completed remote builds in B314346: Diff 431155.Apr 22 2021, 11:22 PM
phab-bot published this revision for review.Apr 22 2021, 11:22 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: emilio. · View Herald TranscriptApr 22 2021, 11:22 PM
boris updated this revision to Diff 431159.Apr 22 2021, 11:35 PM

Refine patches

boris retitled this revision from Bug 1312588 - Part 4: Use enum class for WidthProperty in nsLayoutUtils.cpp. to Bug 1312588 - Part 4: Replace eWidthProperty with the enum class, SizeProperty..Apr 22 2021, 11:35 PM
Harbormaster completed remote builds in B314350: Diff 431159.Apr 22 2021, 11:36 PM
boris added a parent revision: D111506: Bug 1312588 - Part 3: Implement the layout part of fit-content() without the intrinsic contribution..Apr 22 2021, 11:36 PM
boris updated this revision to Diff 432563.Apr 27 2021, 11:24 PM

Rebased

Harbormaster completed remote builds in B315501: Diff 432563.Apr 27 2021, 11:24 PM
boris updated this revision to Diff 433171.Apr 29 2021, 12:51 AM

Refine code

Harbormaster completed remote builds in B315957: Diff 433171.Apr 29 2021, 12:51 AM
boris added a reviewer: layout-reviewers.Apr 29 2021, 12:53 AM
emilio accepted this revision as: emilio.Apr 30 2021, 11:34 AM
emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).

Much nicer :)

This revision is now accepted and ready to land.Apr 30 2021, 11:34 AM
boris updated this revision to Diff 448217.Jun 7 2021, 11:40 PM

Addressed comments and rebased.

Harbormaster completed remote builds in B326994: Diff 448217.Jun 7 2021, 11:40 PM
Closed by commit rMOZILLACENTRALf0de4933e215: Bug 1312588 - Part 4: Replace eWidthProperty with the enum class, SizeProperty. (authored by boris). · Explain WhyJun 8 2021, 5:10 AM
This revision was automatically updated to reflect the committed changes.
boris added a commit: rMOZILLACENTRALf0de4933e215: Bug 1312588 - Part 4: Replace eWidthProperty with the enum class, SizeProperty..
Harbormaster completed remote builds in B327175: Diff 448286.Jul 19 2021, 1:45 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
layout/
base/
47 lines92%
Loading...

Diff 448286

View Options

layout/base/nsLayoutUtils.cpp

Loading...
Privacy · Cookies · Legal