Details

Reviewers

Group Reviewers

Restricted Project
layout-reviewers

Commits

rMOZILLACENTRAL160fb67fad9f: Bug 1312588 - Part 2: Support fit-content() in style. r=emilio

Bugzilla Bug ID

1312588

Summary

Support fit-content for preferred size, min size, and max size. This
patch only implement the style system. For layout part, we will do that
in the following patches.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Build Status

Buildable 327173
Build 421170: arc lint + arc unit

Event Timeline

boris created this revision.Mar 4 2021, 12:38 AM

Herald added a project: secure-revision. · View Herald TranscriptMar 4 2021, 12:38 AM

Harbormaster completed remote builds in B295283: Diff 408012.Mar 4 2021, 12:38 AM

phab-bot published this revision for review.Mar 4 2021, 12:38 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: emilio. · View Herald TranscriptMar 4 2021, 12:38 AM

Retitle

Harbormaster completed remote builds in B295284: Diff 408018.Mar 4 2021, 12:40 AM

boris retitled this revision from Bug 1312588 - Suppoert fit-content() in style. to Bug 1312588 - Support fit-content() in style..Mar 4 2021, 12:40 AM

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

Update

boris retitled this revision from Bug 1312588 - Support fit-content() in style. to Bug 1312588 - Part 2: Support fit-content() in style..Apr 21 2021, 10:08 PM

boris added a child revision: D111506: Bug 1312588 - Part 3: Implement the layout part of fit-content() without the intrinsic contribution..

Harbormaster completed remote builds in B313950: Diff 430607.Apr 21 2021, 10:08 PM

Rebased

Harbormaster completed remote builds in B315499: Diff 432561.Apr 27 2021, 11:24 PM

Update css property db

Harbormaster completed remote builds in B315520: Diff 432595.Apr 28 2021, 1:19 AM

Refine code

boris edited the summary of this revision. (Show Details)Apr 29 2021, 12:51 AM

Harbormaster completed remote builds in B315955: Diff 433169.Apr 29 2021, 12:51 AM

boris added reviewers: Restricted Project, layout-reviewers.Apr 29 2021, 12:52 AM

Enable pref for wpt

Harbormaster completed remote builds in B315976: Diff 433197.Apr 29 2021, 1:54 AM

Looks good, but I wonder why the Func thing in the name? We don't do that anywhere else.

servo/components/style/values/generics/length.rs
163	Why not just `FitContent`?
servo/components/style/values/specified/length.rs
1284	Can we avoid duplicating this?

boris added inline comments.Apr 29 2021, 6:05 PM

servo/components/style/values/generics/length.rs
163	I expect we will update `MozFitContent` to `FitContent` in the future, so use `FitContentFunc` here.
servo/components/style/values/specified/length.rs
1284	Sure. I will factor this out to remove the duplicate. Thanks.

Use macro to remove the duplicates

Harbormaster completed remote builds in B316540: Diff 433865.Apr 30 2021, 12:15 AM

boris marked an inline comment as done.Apr 30 2021, 12:15 AM

Update pref name

Harbormaster completed remote builds in B316541: Diff 433866.Apr 30 2021, 12:18 AM

emilio accepted this revision as: emilio.Apr 30 2021, 11:29 AM

emilio added a project: testing-approved.

emilio added inline comments.

servo/components/style/values/generics/length.rs
216	I think I'd still spell it `FitContentFunction`, but if you feel strongly about those extra characters feel free to leave it as-is.

This revision is now accepted and ready to land.Apr 30 2021, 11:29 AM

Rename enum arm name, FitContentFunction and address comments

Harbormaster completed remote builds in B316971: Diff 434417.Apr 30 2021, 11:22 PM

boris marked an inline comment as done.Apr 30 2021, 11:23 PM

Addressed comments and rebased.

Harbormaster completed remote builds in B326992: Diff 448215.Jun 7 2021, 11:40 PM

Closed by commit rMOZILLACENTRAL160fb67fad9f: Bug 1312588 - Part 2: Support fit-content() in style. r=emilio (authored by boris). · Explain WhyJun 8 2021, 5:10 AM

This revision was automatically updated to reflect the committed changes.

boris added a commit: rMOZILLACENTRAL160fb67fad9f: Bug 1312588 - Part 2: Support fit-content() in style. r=emilio.

Harbormaster completed remote builds in B327173: Diff 448284.Jul 19 2021, 1:45 PM

Bug 1312588 - Part 2: Support fit-content() in style.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 448284

devtools/shared/css/generated/properties-db.js

layout/base/nsLayoutUtils.cpp

layout/generic/nsIFrame.h

layout/generic/nsIFrame.cpp

layout/generic/nsImageFrame.cpp

layout/style/nsComputedDOMStyle.h

layout/style/nsComputedDOMStyle.cpp

layout/style/test/mochitest.ini

layout/style/test/property_database.js

layout/style/test/test_value_computation.html

layout/tables/BasicTableLayoutStrategy.cpp

servo/components/style/values/computed/length.rs

servo/components/style/values/generics/length.rs

servo/components/style/values/specified/length.rs

testing/web-platform/meta/css/css-sizing/dir.ini

testing/web-platform/meta/css/css-sizing/parsing/height-valid.html.ini

testing/web-platform/meta/css/css-sizing/parsing/max-height-valid.html.ini

testing/web-platform/meta/css/css-sizing/parsing/max-width-valid.html.ini

testing/web-platform/meta/css/css-sizing/parsing/min-height-valid.html.ini

testing/web-platform/meta/css/css-sizing/parsing/min-width-valid.html.ini

testing/web-platform/meta/css/css-sizing/parsing/width-valid.html.ini

testing/web-platform/tests/css/css-sizing/parsing/height-valid.html

testing/web-platform/tests/css/css-sizing/parsing/max-height-computed.html

testing/web-platform/tests/css/css-sizing/parsing/max-height-valid.html

testing/web-platform/tests/css/css-sizing/parsing/max-width-computed.html

testing/web-platform/tests/css/css-sizing/parsing/max-width-valid.html

testing/web-platform/tests/css/css-sizing/parsing/min-height-computed.html

testing/web-platform/tests/css/css-sizing/parsing/min-height-valid.html

testing/web-platform/tests/css/css-sizing/parsing/min-width-computed.html

testing/web-platform/tests/css/css-sizing/parsing/min-width-valid.html

testing/web-platform/tests/css/css-sizing/parsing/width-valid.html

Bug 1312588 - Part 2: Support fit-content() in style.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 448284

devtools/shared/css/generated/properties-db.js

layout/base/nsLayoutUtils.cpp

layout/generic/nsIFrame.h

layout/generic/nsIFrame.cpp

layout/generic/nsImageFrame.cpp

layout/style/nsComputedDOMStyle.h

layout/style/nsComputedDOMStyle.cpp

layout/style/test/mochitest.ini

layout/style/test/property_database.js

layout/style/test/test_value_computation.html

layout/tables/BasicTableLayoutStrategy.cpp

servo/components/style/values/computed/length.rs

servo/components/style/values/generics/length.rs

servo/components/style/values/specified/length.rs

testing/web-platform/meta/css/css-sizing/__dir__.ini

testing/web-platform/meta/css/css-sizing/parsing/height-valid.html.ini

testing/web-platform/meta/css/css-sizing/parsing/max-height-valid.html.ini

testing/web-platform/meta/css/css-sizing/parsing/max-width-valid.html.ini

testing/web-platform/meta/css/css-sizing/parsing/min-height-valid.html.ini

testing/web-platform/meta/css/css-sizing/parsing/min-width-valid.html.ini

testing/web-platform/meta/css/css-sizing/parsing/width-valid.html.ini

testing/web-platform/tests/css/css-sizing/parsing/height-valid.html

testing/web-platform/tests/css/css-sizing/parsing/max-height-computed.html

testing/web-platform/tests/css/css-sizing/parsing/max-height-valid.html

testing/web-platform/tests/css/css-sizing/parsing/max-width-computed.html

testing/web-platform/tests/css/css-sizing/parsing/max-width-valid.html

testing/web-platform/tests/css/css-sizing/parsing/min-height-computed.html

testing/web-platform/tests/css/css-sizing/parsing/min-height-valid.html

testing/web-platform/tests/css/css-sizing/parsing/min-width-computed.html

testing/web-platform/tests/css/css-sizing/parsing/min-width-valid.html

testing/web-platform/tests/css/css-sizing/parsing/width-valid.html

Bug 1312588 - Part 2: Support fit-content() in style.
ClosedPublic
Actions

Revision Contents
Changeset List

testing/web-platform/meta/css/css-sizing/dir.ini